🐛 fix undefined menu error #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpprieto
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Thanks @michenly
Curious, did this error happen when linking the new project was linked to Mock.shop? and/or your personal shop?
Can you create a path changeset for cli-hydrogen and hydrogen-create? This will ensure that the CLI is able to scaffold new skeleton projects with these changes
michenly
force-pushed
the
fix-menu-error
branch
2 times, most recently
from
1357a94
to
8fae8ec
Compare
michenly
force-pushed
the
fix-menu-error
branch
from
8fae8ec
to
9e422bd
Compare
Merged
juanpprieto
pushed a commit
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
🐛 Fix menu undefined error found during default creation flow.
WHAT is this pull request doing?
fix by putting a bunch of safe guard checking if those variables value exist
HOW to test your changes?
Recreate this bug by using
npm create @shopify/hydrogen@latestand select no route template.run
npm run dev& load the site in browser to see the following error.Do the same to current set to see the error disappear
Post-merge steps
Checklist