Add GraphQL client type utilities to hydrogen-codegen #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wizardlyhel
reviewed
Dec 18, 2023
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@shopify/hydrogen-codegen': minor | |||
There was a problem hiding this comment.
It's OK to have minor in hydrogen-codegen. Since this is a new feature, it should be minor I think?
wizardlyhel
approved these changes
Dec 18, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts our Storefront client's types as generics and moves them to hydrogen-codegen. This way, we can reuse it in the Customer Account client and it can be helpful for others using hydrogen-codegen standalone.
Note: the hydrogen build bundles the imported types so that we don't need hydrogen-codegen as a dependency in prod.