Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support codegen types in customerAccount client #1587

Merged
merged 19 commits into from
Dec 20, 2023

Conversation

frandiox
Copy link
Contributor

Requires #1584

The customerAccount client can now return types generated by codegen using the same logic we have in the storefront client (refactored and extracted in #1584).

@frandiox frandiox requested review from michenly and a team December 18, 2023 10:50
Copy link
Contributor

@michenly michenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

thou it looks like there are some changes in storefront.schema.json and customer.schema.json, probably not because of this PR thou so merge away!

Base automatically changed from fd-codegen-client-type-refactor to main December 20, 2023 18:33
@frandiox frandiox merged commit 4d6ba3f into main Dec 20, 2023
9 checks passed
@frandiox frandiox deleted the fd-customer-client-codegen branch December 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants