Back to Vite 🎉 #1728
Merged
Back to Vite 🎉 #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
blittle
reviewed
Feb 27, 2024
| * Worker entry module that wraps the user app's entry module. | ||
| */ | ||
| async fetch(request: Request, env: ViteEnv, ctx: any) { | ||
| env.__VITE_SETUP_ENV(request); |
There was a problem hiding this comment.
It modifies globalThis with an utility for the Subrequest Profiler. Once Vite is stable, we can deprecate the code we have in remix-oxygen for this and move it here.
To see more details around how this works, check wrappedBindings in the mini-oxygen.ts file. The setupScripts part comes from the Hydrogen plugin.
blittle
approved these changes
Feb 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental Vite support! This uses the new ViteRuntime released in Vite 5.1.0-beta.6 to make Hydrogen/Remix run on workerd instead of polyfilling APIs.
I've started this as a CLI command to make things easier but we might be able to extract it later as a plugin (most of the Vite code is already separated from the CLI itself).A good chunk of this comes from sapphi-red/vite-envs, especially around WS/HMR.
GraphiQL, Subrequest Profiler, log enhancements, worker devtools, etc. are already integrated 🎉
There are a few things that are not working properly yet:
SourcemapsNeed to make a proper CLI command for vite-build.Fix CSS loading delay in devTo test this locally:
npm inpm run build:pkg -- --forcecd examples/vite,npm run dev|| orLOCAL_DEV=true h2 init --template viteto scaffold a new one.Here's a diagram showing roughly the flow: https://www.tldraw.com/v/VJ2EJE5bJwrBaPYERLjBw?viewport=-284,-93,2090,1186&page=page:U22fjHfK0cK0yNoOgsNYZ