-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopify cookie fix again #2143
Shopify cookie fix again #2143
Conversation
We detected some changes in |
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
*/ | ||
|
||
// Use override domain or current host | ||
let currentDomain = domain || window.document.location.host; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this fail during SSR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's inside a useEffect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thx, didn't notice.
WHY are these changes introduced?
The cookie domain isn't being picked up by default
WHAT is this pull request doing?
Make sure we always have a domain host to work with
useShopifyCookie
HOW to test your changes?
Post-merge steps
Checklist