Shopify cookie fix again #2143
Merged
Shopify cookie fix again #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We detected some changes in |
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
blittle
reviewed
May 22, 2024
| */ | ||
|
|
||
| // Use override domain or current host | ||
| let currentDomain = domain || window.document.location.host; |
There was a problem hiding this comment.
Will this fail during SSR?
There was a problem hiding this comment.
It's inside a useEffect
blittle
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The cookie domain isn't being picked up by default
WHAT is this pull request doing?
Make sure we always have a domain host to work with
useShopifyCookieHOW to test your changes?
Post-merge steps
Checklist