Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes of random things #2150

Merged
merged 1 commit into from
May 24, 2024
Merged

small fixes of random things #2150

merged 1 commit into from
May 24, 2024

Conversation

michenly
Copy link
Contributor

No description provided.

@shopify Shopify
Copy link
Contributor

shopify bot commented May 24, 2024 •
edited
Loading

Oxygen deployed a preview of your small-fixes branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment May 24, 2024 7:55 PM

Learn more about Hydrogen's GitHub integration.

@Shopify Shopify deleted a comment from github-actions bot May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

@michenly michenly merged commit a247da6 into main May 24, 2024
13 checks passed
@michenly michenly deleted the small-fixes branch May 24, 2024 19:54
frandiox
frandiox reviewed May 27, 2024
View reviewed changes
templates/skeleton/app/lib/root-data.ts
return root?.data as SerializeFrom<typeof loader>;
return (root as UIMatch<typeof loader>)?.data;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change probably breaks JSDoc in JS projects. Can you try generating a JS project and see if types work here?
We probably need to change things around here and maybe here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future PR removed this file. But thanks for the reminder!

packages/remix-oxygen/src/index.ts
Comment on lines +22 to +23
unstable_defineLoader,
unstable_defineAction,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need a changeset if we want to release this, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok releasing it whenever we do a release next. Since we dont need to use it just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox frandiox left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michenly @frandiox