Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore classic Remix config file in Vite projects #2379

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Ignore classic Remix config file in Vite projects #2379

merged 3 commits into from
Jul 30, 2024

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jul 29, 2024 •
edited
Loading

Closes #2379

We were not consistent with our priorities reading from Vite config or Remix config in every command. With this PR, every command gives preference to Vite config when both are present, and warns about it:

image

@frandiox frandiox requested a review from a team July 29, 2024 12:15
@shopify Shopify
Copy link
Contributor

shopify bot commented Jul 29, 2024 •
edited
Loading

Oxygen deployed a preview of your fd-fix-cli-vite-legacy branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 30, 2024 9:07 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox mentioned this pull request Jul 29, 2024
Closed
blittle
blittle reviewed Jul 29, 2024
View reviewed changes
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I see a codegen error when running dev. The app still works, but it looks like the codegen process fails because it's trying to load the remix config.

Reproduce by copying the classic remix config to the starter template and running npm run dev.

@frandiox
Copy link
Contributor Author

it looks like the codegen process fails because it's trying to load the remix config.

Good catch, it should be fixed now 👍

@frandiox frandiox requested a review from blittle July 30, 2024 09:06
@frandiox frandiox merged commit c0d7d91 into main Jul 30, 2024
13 checks passed
@frandiox frandiox deleted the fd-fix-cli-vite-legacy branch July 30, 2024 17:17
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blittle blittle blittle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frandiox @blittle