Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes links in onboarding route #509

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Conversation

benjaminsehl
Copy link
Member

Fixes #488 by changing the onboarding route markup to use:

return (
    <>
      <Layout shopName={shopName}>
        {configDone ? <HydrogenLogoBaseColor /> : <HydrogenLogoBaseBW />}
        <h1>Hello, {shopName || 'Hydrogen'}</h1>
        <p>Welcome to your new custom storefront</p>
        <section className="Banner">
          <div>
            <IconBanner />
            <h2>Configure storefront token</h2>
          </div>
          <p>
            You&rsquo;re seeing this because you have not yet configured your
            storefront token. To get started, edit {` `}
            <code>.env</code>. Then, create your first route with the file {` `}
            <code>/app/routes/index.jsx</code>. Learn more about
            {` `}
            <a href="https://shopify.dev/docs/custom-storefronts/hydrogen/environment-variables">
              editing environment variables
            </a>
            and
            <a href="https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development#step-4-create-a-route">
              creating routes
            </a>
            .
          </p>
        </section>
        <ResourcesLinks />
      </Layout>
    </>
  );
}

@benjaminsehl benjaminsehl requested a review from a team February 14, 2023 20:17
@github-actions

This comment has been minimized.

Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably add a changeset: npm run changeset add

@lordofthecactus lordofthecactus merged commit 5634902 into 2023-01 Feb 15, 2023
@lordofthecactus lordofthecactus deleted the bs/hello-world-link-fix branch February 15, 2023 14:28
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hello World index page points to wrong help content
6 participants