Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello World index page points to wrong help content #488

Closed
mcvinci opened this issue Feb 11, 2023 · 0 comments · Fixed by #509
Closed

Hello World index page points to wrong help content #488

mcvinci opened this issue Feb 11, 2023 · 0 comments · Fixed by #509
Assignees

Comments

@mcvinci
Copy link
Contributor

mcvinci commented Feb 11, 2023

What is the location of your example repository?

No response

What version of Hydrogen are you using?

The latest! :)

What version of Remix are you using?

No response

Steps to Reproduce

  1. Create a new Hydrogen Storefront
  2. Start the development server

Expected Behavior

In the Configure storefront token banner, we should probably point to the environment variables and create a route steps instead of the getting started guide.

https://github.com/Shopify/hydrogen/blob/2023-01/packages/cli/src/virtual-routes/routes/index.tsx could include the following update:

return (
    <>
      <Layout shopName={shopName}>
        {configDone ? <HydrogenLogoBaseColor /> : <HydrogenLogoBaseBW />}
        <h1>Hello, {shopName || 'Hydrogen'}</h1>
        <p>Welcome to your new custom storefront</p>
        <section className="Banner">
          <div>
            <IconBanner />
            <h2>Configure storefront token</h2>
          </div>
          <p>
            You&rsquo;re seeing this because you have not yet configured your
            storefront token. To get started, edit {` `}
            <code>.env</code>. Then, create your first route with the file {` `}
            <code>/app/routes/index.jsx</code>. Learn more about
            {` `}
            <a href="https://shopify.dev/docs/custom-storefronts/hydrogen/environment-variables">
              editing environment variables
            </a>
            and
            <a href="https://shopify.dev/docs/custom-storefronts/hydrogen/building/begin-development#step-4-create-a-route">
              creating routes
            </a>
            .
          </p>
        </section>
        <ResourcesLinks />
      </Layout>
    </>
  );
}

Actual Behavior

The Configure storefront token banner contains a link ("connecting a storefront") that points to this getting started guide. This guide doesn't actually contain information about configuring your Storefront API token or setting up your first route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants