Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows paths in development #520

Merged
merged 5 commits into from
Feb 16, 2023
Merged

Fix windows paths in development #520

merged 5 commits into from
Feb 16, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Feb 15, 2023

Closes #476
Closes #499
Closes #529
Includes #528

This one was reported in this comment.

the new URL(file:///${relativeFilePath}) is not accepted on Windows, removing a slash at file:/// so it becomes file:// fixes the problem on Windows

@frandiox
Copy link
Contributor Author

frandiox commented Feb 16, 2023

I've tested this branch on Windows and it seems to work, including:

  • init
  • dev + virtual routes
  • generate route home
  • build
  • preview
  • check routes

@blittle blittle merged commit ce04cd7 into 2023-01 Feb 16, 2023
@blittle blittle deleted the fd-fix-windows-paths branch February 16, 2023 14:20
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
@Andi365
Copy link

Andi365 commented Feb 16, 2023

I am still not able to run run the command "npm create @shopify/hydrogen@latest", this is my log:

npm create @shopify/hydrogen@latest
✔ Choose a template · Demo Store
✔ Choose a language · TypeScript
✔ Where would you like to create your app? · festivalteltet
C:\Users\Ander\AppData\Local\npm-cache\_npx\e1eac94ad41cc36f\node_modules\yoga-layout-prebuilt\yoga-layout\build\Release\nbind.js:53
        throw ex;
        ^

[Error: ENOENT: no such file or directory, lstat 'C:\Users\Ander\AppData\Local\npm-cache\_npx\e1eac94ad41cc36f\node_modules\@shopify\cli-hydrogen\dist\starter-templates\cli-hydrogen@4.0.5\templates\demo-store'] {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'lstat',
  path: 'C:\\Users\\Ander\\AppData\\Local\\npm-cache\\_npx\\e1eac94ad41cc36f\\node_modules\\@shopify\\cli-hydrogen\\dist\\starter-templates\\cli-hydrogen@4.0.5\\templates\\demo-store'
}

Node.js v18.14.0
npm ERR! code 7
npm ERR! path C:\Users\Ander\Documents\GitHub\festivalteltet
npm ERR! command failed
npm ERR! command C:\Windows\system32\cmd.exe /d /s /c create-hydrogen

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Ander\AppData\Local\npm-cache\_logs\2023-02-16T15_31_11_992Z-debug-0.log

Should I run anything before I run the command @frandiox?

@juanpprieto
Copy link
Contributor

@Andi365 we need to cut a new release before the changes are published

@juanpprieto
Copy link
Contributor

We've cut a release https://github.com/Shopify/hydrogen/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants