Improve SEO lib with seo option in loader data response
#591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
juanpprieto
reviewed
Feb 27, 2023
| brand: product?.vendor, | ||
| name: product?.title, | ||
| }, | ||
| } satisfies SeoConfig<Product>; |
juanpprieto
reviewed
Feb 27, 2023
packages/hydrogen/src/seo/seo.ts
Outdated
| @@ -45,7 +45,18 @@ export function Seo({debug}: SeoProps) { | |||
| const routeInfo = {...routeMatch, ...location}; | |||
|
|
|||
| if (handle === undefined || handle.seo === undefined) { | |||
| return []; | |||
| if ( | |||
| routeMatch.data === undefined || | |||
There was a problem hiding this comment.
nit: if (!route?.data?.seo)
cartogram
commented
Feb 27, 2023
| @@ -0,0 +1,153 @@ | |||
| import {createElement} from 'react'; | |||
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #577
This PR implements a new API for SEO as described in the above issue.
I've also added tests for this component which required
react-testingsetup in vitest, though I've kept this setup as minimal as possible to start.WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist