Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt v2 route conventions in demo-store #747

Merged
merged 10 commits into from
Apr 12, 2023
Merged

Adopt v2 route conventions in demo-store #747

merged 10 commits into from
Apr 12, 2023

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Mar 31, 2023 •
edited by frandiox
Loading

To-do:

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@frandiox frandiox mentioned this pull request Apr 4, 2023
Merged
5 tasks
@frandiox frandiox marked this pull request as ready for review April 4, 2023 17:15
@frandiox frandiox requested a review from a team April 4, 2023 17:16
@frandiox frandiox changed the title Adopt v2 route conventions Adopt v2 route conventions in demo-store Apr 4, 2023
frehner
frehner reviewed Apr 6, 2023
View reviewed changes
.changeset/early-jobs-fail.md Outdated

Remix v2 route conventions are just file renames. We just need to ensure when changing file name and file location, the import paths of other files are also updated.

Here is an example list of file renames for the demo store:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a confusing changeset for a developer to read and understand. Can you clarify what we expect developers to do in this release? Is this a breaking change for devs using Hydrogen?

frehner
frehner approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just need to figure out the changeset thing for demo-store, but otherwise 💯

@wizardlyhel wizardlyhel merged commit 21b97dc into 2023-01 Apr 12, 2023
@wizardlyhel wizardlyhel deleted the future-flag-route-convention branch April 12, 2023 15:53
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frehner frehner frehner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wizardlyhel @frehner @frandiox