Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuyNowButton always redirects to checkout when cart is not empty #827

Merged
merged 7 commits into from
May 17, 2023

Conversation

tiwac100
Copy link
Contributor

@tiwac100 tiwac100 commented Apr 27, 2023

Fixes #825 #825

WHAT is this pull request doing?

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

lordofthecactus and others added 3 commits April 20, 2023 14:09
* Revert "Support optional segments in `check routes` CLI command (Shopify#774)"

This reverts commit 2039a4a.

* update package.lock
@tiwac100
Copy link
Contributor Author

I have signed the CLA!

@frehner
Copy link
Contributor

frehner commented Apr 27, 2023

Hello! There appear to be quite a few files changed and updated that aren't really related to the issue you're trying to solve here. Do you mind fixing that?

@frehner frehner requested review from frehner and removed request for lordofthecactus May 17, 2023 15:37
@frehner frehner merged commit 2e1e459 into Shopify:2023-04 May 17, 2023
5 of 8 checks passed
@frehner frehner mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] BuyNowButton always redirects to checkout when cart is not empty
4 participants