[Bug] BuyNowButton always redirects to checkout when cart is not empty

[tiwac100]

What is the location of your example repository?

No response

Which package or tool is having this issue?

hydrogen-react

What version of that package or tool are you using?

2023-04

What version of Remix are you using?

No response

Steps to Reproduce

1. Add an AddToCartButton and BuyNowButton on a product page.
2. Add the product to cart using the AddToCartButton

Expected Behavior

The user only gets redirected to checkout when the BuyNowButton is actually clicked.

Actual Behavior

The user gets redirect as soon as an item is in the cart and a BuyNowButton is present on the current page.

[tiwac100]

The reason for this is BuyNowButton just checks if a checkoutUrl is present but never verifies it was actually clicked before redirecting:

hydrogen/packages/hydrogen-react/src/BuyNowButton.tsx

Lines 43 to 47 in a783b42

	useEffect(() => {
	if (checkoutUrl) {
	window.location.href = checkoutUrl;
	}
	}, [checkoutUrl]);

A simple solution would be to use if(loading && checkoutUrl).

[CSpencerND]

Yes, Just instantly goes to checkout without having to click the button.