Skip cache logic when mode is no-store #964
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were still running all the cache logic when mode is
no-store
. This PR changes it to skip the whole cache logic when this mode is specified.This change means we are not reading from cache anymore in this mode. Technically, the "no-store" only signals "don't write", not necessarily "don't read and return an existing cached response". But I think this might be OK?
Or should we keep reading (checking for existing responses) and only skip writing? That would only be useful when the mode changes across requests depending on some condition... not sure if this would ever be desired.
Checklist