Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary SFAPI versions in Codegen for development #970

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jun 1, 2023

Allow specifying an SFAPI version to generate types during development.
This can be useful for testing unstable/new features. cc @juanpprieto

h2 codegen-unstable --watch --force-sfapi-version <version>[:<token>]

When using this, codegen will generate all the types for the specified version (and token) and ignore the existing types in @shopify/hydrogen/storefront-api-types.

Note: not adding a changeset for the CLI here since the new flag is hidden and we will use this only when developing Hydrogen itself locally.

@frandiox frandiox changed the title [WIP] Allow arbitrary SFAPI versions in Codegen for development Allow arbitrary SFAPI versions in Codegen for development Jun 2, 2023
@frandiox frandiox marked this pull request as ready for review June 2, 2023 05:04
@frandiox frandiox requested review from a team and juanpprieto June 2, 2023 05:04
Copy link
Contributor

@juanpprieto juanpprieto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Screenshot 2023-06-05 at 10 45 36 AM Screenshot 2023-06-05 at 10 46 08 AM

@juanpprieto juanpprieto merged commit 6b8537b into 2023-04 Jun 5, 2023
@juanpprieto juanpprieto deleted the fd-codegen-inline-sfapi branch June 5, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants