Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol automatically to storeDomain #985

Merged
merged 4 commits into from Jun 8, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jun 7, 2023

Another minor improvement similar to #984 .
This starts adding https:// automatically if missing to storeDomain:

const {storefront} = createStorefrontClient({
   // ...
   privateStorefrontToken: env.PRIVATE_STOREFRONT_API_TOKEN,
-  storeDomain: `https://${env.PUBLIC_STORE_DOMAIN}`,
+  storeDomain: env.PUBLIC_STORE_DOMAIN,
   storefrontId: env.PUBLIC_STOREFRONT_ID,
 });

@frandiox frandiox requested a review from a team June 7, 2023 02:55
Copy link
Contributor

@wizardlyhel wizardlyhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have a nitpick. Otherwise all good

packages/hydrogen-react/src/storefront-client.ts Outdated Show resolved Hide resolved
@frandiox frandiox merged commit 7b4afea into 2023-04 Jun 8, 2023
10 checks passed
@frandiox frandiox deleted the fd-store-domain-protocol branch June 8, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants