-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mock.shop as a storeDomain
#986
Conversation
This comment has been minimized.
This comment has been minimized.
@teddyhwang @darius-gai — the permission errors for customers, any thoughts on that? intentional? want to keep it? |
I don't recall but we might have just forgotten that scope. The only scope we were intentional about not adding was checkout mutations. feel free to add the scope and generate a new token! |
Builds on top of #985 , and is related to the new onboarding in #913
Tiny change to support
mock.shop
as astoreDomain
. Any call tostorefront.query(...)
will hit the mock.shop instead of the storefront API.Note that mock.shop doesn't work for every query. For example, it throws permission errors when trying to read customer information.
🎩 To test it, add
PUBLIC_STORE_DOMAIN="mock.shop"
to the.env
file in demo-store template, and comment out thecustomer { ... }
selection part of theCartFragment
inroot.tsx
(not supported in mock.shop).