Merge pull request #427 from powerhome/unknown-not-synced

When resources don't exist, their status is Not Found

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 *Bug fixes*
 - Attempting to deploy from a directory that only contains `secrets.ejson` will no longer fail deploy ([#416](https://github.com/Shopify/kubernetes-deploy/pull/416))
+- Resources which don't exist will be reported as "Not Found" rather than "Unknown"
 
 *Other*
 - Update kubeclient gem to 4.2.2. Note this replaces the `KubeclientBuilder::GoogleFriendlyConfig` class with `KubeclientBuilder::KubeConfig` ([#418](https://github.com/Shopify/kubernetes-deploy/pull/418))

lib/kubernetes-deploy/kubernetes_resource.rb

@@ -179,7 +179,7 @@ def observed_generation
     end
 
     def status
-      exists? ? "Exists" : "Unknown"
+      exists? ? "Exists" : "Not Found"
     end
 
     def type

lib/kubernetes-deploy/kubernetes_resource/config_map.rb

@@ -8,7 +8,7 @@ def deploy_succeeded?
     end
 
     def status
-      exists? ? "Available" : "Unknown"
+      exists? ? "Available" : "Not Found"
     end
 
     def deploy_failed?

lib/kubernetes-deploy/kubernetes_resource/ingress.rb

@@ -4,7 +4,7 @@ class Ingress < KubernetesResource
     TIMEOUT = 30.seconds
 
     def status
-      exists? ? "Created" : "Unknown"
+      exists? ? "Created" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/persistent_volume_claim.rb

@@ -4,7 +4,7 @@ class PersistentVolumeClaim < KubernetesResource
     TIMEOUT = 5.minutes
 
     def status
-      exists? ? @instance_data["status"]["phase"] : "Unknown"
+      exists? ? @instance_data["status"]["phase"] : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/pod_disruption_budget.rb

@@ -4,7 +4,7 @@ class PodDisruptionBudget < KubernetesResource
     TIMEOUT = 10.seconds
 
     def status
-      exists? ? "Available" : "Unknown"
+      exists? ? "Available" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/pod_template.rb

@@ -2,7 +2,7 @@
 module KubernetesDeploy
   class PodTemplate < KubernetesResource
     def status
-      exists? ? "Available" : "Unknown"
+      exists? ? "Available" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/resource_quota.rb

@@ -4,7 +4,7 @@ class ResourceQuota < KubernetesResource
     TIMEOUT = 30.seconds
 
     def status
-      exists? ? "In effect" : "Unknown"
+      exists? ? "In effect" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/role.rb

@@ -4,7 +4,7 @@ class Role < KubernetesResource
     TIMEOUT = 30.seconds
 
     def status
-      exists? ? "Created" : "Unknown"
+      exists? ? "Created" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/role_binding.rb

@@ -4,7 +4,7 @@ class RoleBinding < KubernetesResource
     TIMEOUT = 30.seconds
 
     def status
-      exists? ? "Created" : "Unknown"
+      exists? ? "Created" : "Not Found"
     end
 
     def deploy_succeeded?

lib/kubernetes-deploy/kubernetes_resource/service_account.rb

@@ -4,7 +4,7 @@ class ServiceAccount < KubernetesResource
     TIMEOUT = 30.seconds
 
     def status
-      exists? ? "Created" : "Unknown"
+      exists? ? "Created" : "Not Found"
     end
 
     def deploy_succeeded?