Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When resources don't exist, their status is Not Found #427

Merged
merged 1 commit into from
Feb 27, 2019
Merged

When resources don't exist, their status is Not Found #427

merged 1 commit into from
Feb 27, 2019

Conversation

benlangfeld
Copy link
Contributor

Fixes #321

dturn
dturn approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. This PR looks good to me. Context for additional people is that in phase 2 we'll no longer show a mix of "unknown" and "not found"
screen shot 2019-02-27 at 9 24 55 am

timothysmith0609
timothysmith0609 approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@timothysmith0609 timothysmith0609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was something I found a bit confusing as well so glad to see it getting polished.

@dturn dturn merged commit 38f2085 into Shopify:master Feb 27, 2019
@timothysmith0609 timothysmith0609 temporarily deployed to rubygems February 27, 2019 20:41 Inactive
@dturn dturn mentioned this pull request Feb 27, 2019
Merged
@benlangfeld benlangfeld deleted the unknown-not-synced branch February 27, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dturn dturn dturn approved these changes

@timothysmith0609 timothysmith0609 timothysmith0609 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benlangfeld @dturn @timothysmith0609