Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $TASK_ID as deploy ID when running in Shipit #136

Closed
KnVerey opened this issue Jul 18, 2017 · 0 comments
Closed

Use $TASK_ID as deploy ID when running in Shipit #136

KnVerey opened this issue Jul 18, 2017 · 0 comments
Labels
🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 ✨ enhancement Improvement or small feature 👋 new contributor Good for newcomers

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jul 18, 2017

Shipit exposes a $TASK_ID to its deploy scripts. IMO we should be using this when present instead of generating a new one.
@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Jul 19, 2017
@KnVerey KnVerey added the 👋 new contributor Good for newcomers label Oct 30, 2017
@KnVerey KnVerey mentioned this issue Dec 19, 2017
Closed
22 tasks
@KnVerey KnVerey added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Jan 9, 2019
benlangfeld added a commit to powerhome/krane that referenced this issue Feb 27, 2019
@benlangfeld
Better Shipit TASK_ID integration (deployment_id)
7815b2e 
Closes Shopify#136
@benlangfeld benlangfeld mentioned this issue Feb 27, 2019
Merged
timothysmith0609 pushed a commit that referenced this issue Mar 4, 2019
@benlangfeld @timothysmith0609
Better Shipit TASK_ID integration (deployment_id)
5c4a7b9 
Closes #136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 ✨ enhancement Improvement or small feature 👋 new contributor Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnVerey