Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exists? "Unknown" -> "Not found" #321

Closed
dturn opened this issue Jul 20, 2018 · 0 comments
Closed

exists? "Unknown" -> "Not found" #321

dturn opened this issue Jul 20, 2018 · 0 comments
Labels
✨ enhancement Improvement or small feature 👋 new contributor Good for newcomers

Comments

@dturn
Copy link
Contributor

dturn commented Jul 20, 2018

KubernetesResource#exists? returns "Unknown" if the resource hasn't successfully synced. This isn't very helpful. Change it to return "Not Found" which better describes the issue.

https://github.com/Shopify/kubernetes-deploy/pull/296/files#r204130704
@dturn dturn mentioned this issue Jul 20, 2018
Merged
@KnVerey KnVerey added the 👋 new contributor Good for newcomers label Jul 20, 2018
@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Jan 9, 2019
benlangfeld added a commit to powerhome/krane that referenced this issue Feb 27, 2019
@benlangfeld
When resources don't exist, their status is Not Found
7df71b5 
Fixes Shopify#321
@benlangfeld benlangfeld mentioned this issue Feb 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement Improvement or small feature 👋 new contributor Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KnVerey @dturn