Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent preflight validations for all tasks #344

Closed
KnVerey opened this issue Oct 9, 2018 · 3 comments
Closed

Consistent preflight validations for all tasks #344

KnVerey opened this issue Oct 9, 2018 · 3 comments
Assignees
Labels
🛠️ sustainability Technical enhancement or debt repayment krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Oct 9, 2018

Follow-up to #337

The deploy task already checks whether it can reach the API server before proceeding, so that it can fail with a relevant message instead of failing whichever other request happens to be made first. We should do the same in the runner task. In fact, we should make sure that all globally applicable preflight validations are done consistently by all four of our tasks. One possible approach would be to introduce a config validator object for this purpose, as prototyped here: https://github.com/Shopify/kubernetes-deploy/compare/config_validator.

  • Determine all of the appropriate pre-flight validations should be in place across all tasks
  • Make sure they are being executed consistently (including order)

Considerations

  • Maybe we make a generic validation class that can be reused or something specific for each task
@KnVerey KnVerey changed the title [kubernetes-run] Add a context check to the preflight validations Consistent preflight validations for all tasks Jan 9, 2019
@KnVerey KnVerey added 🛠️ sustainability Technical enhancement or debt repayment 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 labels Jan 9, 2019
@dturn dturn self-assigned this Aug 15, 2019
@dturn
Copy link
Contributor

dturn commented Aug 30, 2019

#533 Added a TaskConfig and TaskConfigValidator to each task. But it only added the full set of pre-flight validations to the RestartTask. We need to add it to the remaining tasks to close out this issue.

When working on adding the full set of pre-flight validations to the remaining tasks, consider if we need sub classes like DeployTaskConfig and DeployTaskConfigValidator you can take inspiration from https://github.com/Shopify/kubernetes-deploy/compare/config_validator (or punt this to a new issue).

@dturn dturn removed their assignment Aug 30, 2019
@dirceu dirceu self-assigned this Sep 12, 2019
@RyanBrushett
Copy link
Contributor

We should look into how we report warning/errors as part of this too.

See this comment for why I mention this. Thanks @dirceu !

@dturn
Copy link
Contributor

dturn commented Oct 7, 2019

Done.

@dturn dturn closed this as completed Oct 7, 2019
@ghost ghost added the krane [ProdX-GSD] label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ sustainability Technical enhancement or debt repayment krane [ProdX-GSD] 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229
Projects
None yet
Development

No branches or pull requests

5 participants