-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TaskConfigValidator for RunnerTask #554
Conversation
7969a80
to
85939db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My two big concerns are if we really need a RunnerTaskConfig
class. But also that we haven't lost coverage by the removed tests.
85939db
to
71f7ce7
Compare
👍 I now added integration tests that make essentially the same assertions we had before, just in case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, one quick question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for adding the logger statements :)
5a9ff64
to
34b3871
Compare
Fixed rubocop warning and added changelog entry. Will merge once CI is green. |
What are you trying to accomplish with this PR?
Fix part of #344 by using all supported
TaskConfigValidator
validations inkubernetes-deploy run
(plus additional ones to validateargs
andtemplate
).How is this accomplished?
In the first commit I enabled all validations from
TaskConfigValidator
and updated error messages in tests accordingly. I also chose to delete the unit tests we had forRunnerTask
because:In the second commit I created
RunnerTaskConfig
andRunnerTaskConfigValidator
and moved the validation ofargs
andtemplate
there to follow the same pattern for all validations.What could go wrong?
The same as #533: because we need to unify validations that are done slightly differently we are changing the error class that gets raised as well as the wording. If people were rescuing these errors or matching text this will be a breaking change.