Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support label-based sub-namespace resource management #411

Closed
KnVerey opened this issue Jan 9, 2019 · 2 comments · Fixed by #439
Closed

Support label-based sub-namespace resource management #411

KnVerey opened this issue Jan 9, 2019 · 2 comments · Fixed by #439
Labels
🆕 feature Makes something new possible 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Jan 9, 2019

i.e. revive and merge #235
@KnVerey KnVerey added the 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229 label Jan 9, 2019
@KnVerey KnVerey mentioned this issue Jan 9, 2019
Closed
22 tasks
@KnVerey KnVerey added the 🆕 feature Makes something new possible label Jan 9, 2019
@benlangfeld
Copy link
Contributor

What remains to be done on #235 to get it merged? A skim of the review comments suggests they were all either addressed or withdrawn.

@KnVerey
Copy link
Contributor Author

KnVerey commented Jan 24, 2019

IIRC there was an unresolved gotcha related to selector-based pruning of secrets derived from EJSON. At this point, the PR is a year old and will need a major rebase. But you're right that it was very close to the finish line.

This was referenced Feb 20, 2019
Closed
Merged
This was referenced Feb 27, 2019
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🆕 feature Makes something new possible 🚀 1.0 requirement https://github.com/Shopify/kubernetes-deploy/issues/229
Projects
None yet
Milestone
No milestone
2 participants
@benlangfeld @KnVerey