Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more resource types #46

Closed
KnVerey opened this issue Feb 27, 2017 · 7 comments
Closed

Support more resource types #46

KnVerey opened this issue Feb 27, 2017 · 7 comments
Labels
✨ enhancement Improvement or small feature

Comments

@KnVerey
Copy link
Contributor

KnVerey commented Feb 27, 2017

We only selected a few that our own apps commonly use for the initial rollout. Currently unrecognized types will be kubectl applied and a warning will be logged about the fact that the script does not know how to check whether they actually came up.

@KnVerey KnVerey added the ✨ enhancement Improvement or small feature label Feb 27, 2017
@KnVerey
Copy link
Contributor Author

KnVerey commented Mar 14, 2017

I've now seen StatefulSet, DaemonSet and Secret 😱 in use by our apps (the latter for a case that should be using a configmap). Some people have also tested HPAs, but I'm not sure anyone is using them for real yet.

@wfarr
Copy link
Contributor

wfarr commented Apr 7, 2017

Maybe a default fallback handler that does a fire-and-forget kubectl apply? Most of these resource types probably don't need custom blocking behavior.

@KnVerey
Copy link
Contributor Author

KnVerey commented Apr 7, 2017

Maybe a default fallback handler that does a fire-and-forget kubectl apply?

That's exactly what already happens (and it logs a warning that it did so). 😄

@karanthukral
Copy link
Contributor

Daemon Sets also use ownerReferences and revision to match with pods. We should be able to replicate the logic currently used by deployments currently

@jpatters
Copy link

jpatters commented Apr 5, 2018

+1 for HPA support

@dturn
Copy link
Contributor

dturn commented Aug 8, 2018

HPA support has been merged #305.

@KnVerey
Copy link
Contributor Author

KnVerey commented Aug 8, 2018

With HPA in, I think we can actually close this. I don't see any unsupported resources left that actually report a status, i.e. where supporting them explicitly would actually improve deploy behaviour. For example, there are a bunch of policy objects (LimitRange, PodSecurityPolicy, Role, RoleBinding...) we don't model, but they're typically controller-managed, and we could trivially add them on-demand if others say they do want to use kubernetes-deploy to manage them. Adding resources like those effectively just suppresses the warning.

@KnVerey KnVerey closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement Improvement or small feature
Projects
None yet
Development

No branches or pull requests

5 participants