Add Simplecov/Codecov #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Codecov, following the instructions in the Vault. See the report for this branch here: https://codecov.io/gh/Shopify/kubernetes-deploy/branch/codecov
The biggest gap is in coverage for the Shopify-specific TPRs. We have plans to replace those classes with generic CustomResourceDefinition support, so I don't think it is worth trying to cover them (which would be difficult, since minikube doesn't have those closed-source controllers).
With this in place, I think we can close #47. We've added a lot of integration tests for both main flows and corner cases since then, and it shows in our coverage levels. We don't have as much in the way of unit tests, but I'm satisfied by the coverage overall and the ease of increasing it. Consequently, I don't think there's particular value in keeping #48 open either.
Closes #47
Closes #48