Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.25.0 #432

Merged
merged 7 commits into from
Feb 27, 2019
Merged

Version 0.25.0 #432

merged 7 commits into from
Feb 27, 2019

Conversation

timothysmith0609
Copy link
Contributor

@timothysmith0609 timothysmith0609 commented Feb 27, 2019

Bumps to 0.25.0

Bug fixes

Attempting to deploy from a directory that only contains secrets.ejson will no longer fail deploy (#416)
Resources which don't exist will be reported as "Not Found" rather than "Unknown"

Other

Update kubeclient gem to 4.2.2. Note this replaces the KubeclientBuilder::GoogleFriendlyConfig class with KubeclientBuilder::KubeConfig (#418)

@benlangfeld
Copy link
Contributor

Is it possible to wait on some of the PRs which appear to be very close to being merged?

@KnVerey
Copy link
Contributor

KnVerey commented Feb 27, 2019

Is it possible to wait on some of the PRs which appear to be very close to being merged?

I'd rather cut this as a separate version so that administrators can pick up the apply-errors-can-leak-secrets patch we just merged without also picking up the secret pruning (which may require preparatory action on their part). In general I don't have a problem with releasing multiple versions close together in time as long as each contains a worthy changeset.

Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add that #418 is also expected to resolve #396. That could be a bug fix or a feature (I doubt EKS ever worked before).

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated

*Bug fixes*
- Attempting to deploy from a directory that only contains `secrets.ejson` will no longer fail deploy ([#416](https://github.com/Shopify/kubernetes-deploy/pull/416))
- Resources which don't exist will be reported as "Not Found" rather than "Unknown"
- Remove the risk of sending decrypted EJSON secrets to output([#431]https://github.com/Shopify/kubernetes-deploy/pull/431))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Remove the risk of sending decrypted EJSON secrets to output([#431]https://github.com/Shopify/kubernetes-deploy/pull/431))
- Remove the risk of sending decrypted EJSON secrets to output([#431](https://github.com/Shopify/kubernetes-deploy/pull/431))

CHANGELOG.md Outdated

*Other*
- Update kubeclient gem to 4.2.2. Note this replaces the `KubeclientBuilder::GoogleFriendlyConfig` class with `KubeclientBuilder::KubeConfig` ([#418](https://github.com/Shopify/kubernetes-deploy/pull/418))
- Update kubeclient gem to 4.2.2. Note this replaces the `KubeclientBuilder::GoogleFriendlyConfig` class with `KubeclientBuilder::KubeConfig` ([#418](https://github.com/Shopify/kubernetes-deploy/pull/418)). This resolves [#396](https://github.com/Shopify/kubernetes-deploy/issues/396) and should allow connections to non-GCP clusters (EKS, etc.).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-GCP clusters

Nit: We do already work with some non-GCP clusters... it depends on the auth method. Maybe "should allow us to support more cluster authentication methods (including EKS auth)."?

@timothysmith0609 timothysmith0609 merged commit 4ec1f13 into master Feb 27, 2019
@timothysmith0609 timothysmith0609 deleted the bump_to_0_25 branch February 27, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants