Update rubocop and re-lint files #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnVerey
commented
Apr 24, 2019
| @@ -53,7 +53,7 @@ def build(namespace:, context:, definition:, logger:, statsd_tags:, crd: nil) | |||
|
|
|||
| def class_for_kind(kind) | |||
| if KubernetesDeploy.const_defined?(kind) | |||
| KubernetesDeploy.const_get(kind) # rubocop:disable Sorbet/ConstantsFromStrings | |||
There was a problem hiding this comment.
Rubocop locally complains that disabling this cop has no effect, but then Policial fails without it. I added a general exclusion to the main rubocop config instead. We're not using Sorbet.
dturn
approved these changes
Apr 24, 2019
| @@ -399,7 +399,7 @@ def dummy_events(start_time) | |||
| count: 3, | |||
| last_seen: start_time + 3.seconds, | |||
| reason: "FailedSync", | |||
| message: <<~STRING | |||
| message: <<~STRING, | |||
There was a problem hiding this comment.
Is this really where the , goes?
There was a problem hiding this comment.
Yep--it's like when you chain a method on a heredoc, this is where it goes (<<~STRING.strip for example). I agree this comma looks stupid though. 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Update our rubocop compliance. I noticed that it was correcting untouched code when I ran it on my last PR.
How is this accomplished?
gem install rubocop, delete the styleguide cache,rubocop -aand then fix what couldn't be auto-corrected.What could go wrong?
Committing unintentional changes, because I actually did this on my other branch and pulled it over from there.
@Shopify/cloudx