Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Thor min version to 1.0 #684

Merged
merged 10 commits into from
Feb 12, 2020
Merged

Set Thor min version to 1.0 #684

merged 10 commits into from
Feb 12, 2020

Conversation

timothysmith0609
Copy link
Contributor

@timothysmith0609 timothysmith0609 commented Feb 6, 2020

What are you trying to accomplish with this PR?
Component of #658
I originally attempted to add the repeatable option to --filenames in this PR, but unfortunately there appears to be a bug (I suspect in Thor itself) that precludes that. I'm going to take a look at that after this PR merges.

Sets the lower bound of the Thor version we use to 1.0. This version includes parsing support for - as flag arguments (required to get rid of --stdin flag in favour of --filenames -).

How is this accomplished?

  • Bump the lower bound for Thor in the gemspec
  • Remove references in README for stdin, edit references to --filenames to indicate how to read from STDIN
  • Update tests
  • Fix code references

What could go wrong?
Small change across a module of the system (the CLI layer), so this should be a fairly safe and testable change. More difficult might be ensuring we clean up all references to the now-obsolete flags.

@timothysmith0609 timothysmith0609 changed the title Thor 1 0 Set Thor min version to 1.0 Feb 6, 2020
@timothysmith0609 timothysmith0609 marked this pull request as ready for review February 6, 2020 20:23
Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a Deprecations its a removal. Which I wasn't expecting, I though we'd just stop documenting it.

If we're going to remove it without a major version bump I think we need to have at least one minor version that supports both.

@timothysmith0609
Copy link
Contributor Author

timothysmith0609 commented Feb 7, 2020

I though we'd just stop documenting it.

You're right, I was overzealous, here. I've added back the stdin flag to deploy, global-deploy, and render. The documentation still has all references to --stdin removed, so it's undocumented now. I've also made sure the tests exercise cases were we use either --filenames, --stdin, and their combination

I've also added a deprecation warning to the logs if we end up parsing the stdin option.

lib/krane/cli/global_deploy_command.rb Outdated Show resolved Hide resolved
@timothysmith0609 timothysmith0609 merged commit eee5c4d into master Feb 12, 2020
@timothysmith0609 timothysmith0609 deleted the thor_1_0 branch February 12, 2020 14:22
@timothysmith0609 timothysmith0609 mentioned this pull request Feb 12, 2020
1 task
KnVerey pushed a commit that referenced this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants