-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Thor min version to 1.0 #684
Conversation
b5dca37
to
e6ce4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a Deprecations
its a removal. Which I wasn't expecting, I though we'd just stop documenting it.
If we're going to remove it without a major version bump I think we need to have at least one minor version that supports both.
You're right, I was overzealous, here. I've added back the
|
6f2fa56
to
4940b4e
Compare
What are you trying to accomplish with this PR?
Component of #658
I originally attempted to add the repeatable option to
--filenames
in this PR, but unfortunately there appears to be a bug (I suspect in Thor itself) that precludes that. I'm going to take a look at that after this PR merges.Sets the lower bound of the Thor version we use to 1.0. This version includes parsing support for
-
as flag arguments (required to get rid of--stdin
flag in favour of--filenames -
).How is this accomplished?
--filenames
to indicate how to read from STDINWhat could go wrong?
Small change across a module of the system (the CLI layer), so this should be a fairly safe and testable change. More difficult might be ensuring we clean up all references to the now-obsolete flags.