Add version exception for FrontendConfig resource for GKE #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ``` error: no matches for kind "FrontendConfig" in version "networking.gke.io/v1" ``` when pruning resources on GKE clusters >= 1.17.9-gke.6300 See Shopify#687 for more details
timothysmith0609
approved these changes
Oct 26, 2020
|
CI passed (one day we'll fix the CI linting for external branches). |
|
We'll cut a release for this tomorrow |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
when pruning resources on GKE clusters >= 1.17.9-gke.6300
See #687 for more details. Not exactly sure what the best way to test it, it's really just data and would require adding some CRD configured exactly like Google's is to a test cluster.