Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same timeout everywhere in resource discovery #813

Merged
merged 2 commits into from
Apr 5, 2021

Conversation

dturn
Copy link
Contributor

@dturn dturn commented Mar 9, 2021

What are you trying to accomplish with this PR?
Make krane work in high latency envs

close: #805

How is this accomplished?
Using the same timeout length everywhere.

What could go wrong?
Deploys get slower
CI times are significantly higher ...

@dturn dturn marked this pull request as ready for review March 10, 2021 00:01
@dturn dturn requested a review from a team as a code owner March 10, 2021 00:01
Copy link
Contributor

@timothysmith0609 timothysmith0609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There and back again...

@dturn dturn merged commit 6e0a009 into master Apr 5, 2021
@dturn dturn deleted the same-timeout-everywhere branch April 5, 2021 15:19
@casperisfine casperisfine temporarily deployed to rubygems April 13, 2021 14:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Krane 2.1.6 unable to deploy due to latency reaching cluster
3 participants