Predeploy RoleBinding before unmanaged pods #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lautis
force-pushed
the
predeploy-role-binding
branch
from
bc9cba8
to
4c03936
Compare
dturn
approved these changes
Oct 22, 2018
| end | ||
|
|
||
| def deploy_succeeded? | ||
| exists? |
There was a problem hiding this comment.
As far as I can tell there is no status field for this resource so the success condition seems reasonable
KnVerey
reviewed
Oct 23, 2018
lautis
force-pushed
the
predeploy-role-binding
branch
from
63ab19f
to
3de9a14
Compare
|
Could you please rebase this? Code LGTM but tests are failing because you're using the new constant |
RoleBindings should be deployed before unmanaged pods. This matters when RoleBindings define Pod Security Policies. This might prevent unmanaged pods from starting unless RoleBinding has been set up. Regular pods retry so the race condition would not break anything.
lautis
force-pushed
the
predeploy-role-binding
branch
from
3de9a14
to
79d1aef
Compare
|
Rebased. I used Docker for Mac for testing from #356, which almost worked as it didn't see to like context name "docker-for-desktop" rather than "docker-for-mac". Didn't realise that it also changed the constant name. |
KnVerey
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoleBindings should be deployed before unmanaged pods. This matters when RoleBindings define Pod Security Policies. This might prevent unmanaged pods from starting unless RoleBinding has been set up and the deployment fails.
For normal deployments only scenario it already works. Even if there is a race condition, it works as the pods retry.
Should there be a separate resource type? Other similar resource types seemed to have also the corresponding class defined.