Add support for Krane annotations #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
force-pushed
the
krane-annotations
branch
from
0361d4f
to
948d680
Compare
RyanBrushett
force-pushed
the
krane-annotations
branch
5 times, most recently
from
246ffc8
to
f643581
Compare
Warning looks like this
Weird that it doesn't colour the first line of the warning message as yellow. |
RyanBrushett
changed the title
dturn
reviewed
Sep 6, 2019
test/unit/kubernetes-deploy/kubernetes_resource/deployment_test.rb
Outdated
Show resolved
Hide resolved
RyanBrushett
force-pushed
the
krane-annotations
branch
2 times, most recently
from
8f95924
to
3098276
Compare
dturn
reviewed
Sep 9, 2019
|
Not at all, I went back over it and got it sorted out. Sorry for overlooking that. Ready for another 👀 |
dturn
approved these changes
Sep 10, 2019
RyanBrushett
force-pushed
the
krane-annotations
branch
from
1b310da
to
b2c4633
Compare
dirceu
approved these changes
Sep 11, 2019
RyanBrushett
force-pushed
the
krane-annotations
branch
from
6e7b7ad
to
3b4daed
Compare
- Deprecate kubernetes-deploy.shopify.io annotations - Edit readme to reflect new annotations - Add annotation deprecation changelog entry - Add warning on use of depricated annotation during deploy task co-authored-by: Ryan Brushett <ryan.brushett@shopify.com>
RyanBrushett
force-pushed
the
krane-annotations
branch
from
3b4daed
to
d237e0c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Closes: #525
As described in the issue, we want to support new Krane annotations while allowing the current
kubernetes-deployannotations to remain in use.I think we should break this down into three steps:
kubernetes-deployannotation is used, indicating thatkrane.shopify.ioshould be used insteadHow is this accomplished?
(Chatted with @dturn and we decided that duplicating every test that makes use of an annotated resource is unnecessary)
What could go wrong?
kubernetes-deploy.shopify.io/ejson-secret). Discussion about it's purpose can be found here: Deploy secrets in DeployTask like other resources #424. I've excluded it from this PR - thinking we might want to tackle that for this issue instead Rename code references ofkubernetes-deploytokrane#527 since it's really just a tracking reference.