Drop k8s 1.10 support and add 1.15 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysmith0609
approved these changes
Sep 5, 2019
RyanBrushett
reviewed
Sep 5, 2019
RyanBrushett
approved these changes
Sep 6, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Our (un)official Kubernetes version support policy is everything from the oldest version on gke to most recent officially released version. 1.10 is not supported by GKE so we should drop it.
1.15 is also out so we should support it as well.
My plan is to merge around the same time as #536 , though I'd be willing to merge this earlier if requested.
closes: #544
How is this accomplished?
Same as previous PRs:
#409
What could go wrong?
We break compatibility with 1.10 and people were relying on it.