Optionally throttle based on the lag of a single slave #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option `:check_only` expects a lambda returning a connection config fragment for the specific slave; however, beware that credentials for the master are use to connect to this slave.
|
@jasonhl , can you take a look at this? |
jasonhl
reviewed
Nov 2, 2016
| end | ||
| else | ||
| slave_config = @check_only.call |
There was a problem hiding this comment.
Is it worth adding a check (and a corresponding test...) here in case the parameter passed in is not something that responds to "call"?
There was a problem hiding this comment.
Yes, I think it makes sense. I'll add it.
|
Looks good. Just one question/comment. |
|
@jasonhl: I've just added that check. |
jasonhl
approved these changes
Nov 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option
:check_onlyexpects a lambda returning a connection config fragment for the specific slave; however, beware that credentials for the master are use to connect to this slave.R: @sroysen, @jordanwheeler.