Nested search in where filter

[andershagbard]

This PR allows nested search in where filter.

{% assign blocks = section.blocks | where: 'settings.some_setting' %}
{% assign blocks = section.blocks | where: 'settings.some_setting', 'blue' %}

Resolves #1388

[henryiii]

This would be really nice in sort, too. I have a date.start I'd like to sort by, and item.dig(*property.split('.', -1)) would work very well there too I'd think.

[dylanahsmith]

This shouldn't bring any breaking changes to Shopify, but could bring breaking changes to other platforms using Liquid, as it won't consider attributes with dots.

I'm not sure if that is actually the case. Doesn't Shopify support JSON metafield types? If the where filter were used on some parsed json blob, then I would think it could end up filtering on keys with a period in them.

[dylanahsmith]

This would no longer check all the array elements. Also, this seems more restrictive to have it only work for Hash objects rather than supporting any object that responds to [] as the above line implies.

[andershagbard]

I have added this check:

is_deep = ary.first.is_a?(Hash) && ary.first.include?(property) == false

Is it good enough to only check the first item? I think that checking all items wouldn't perform too well.

Alternatively, we can do something like:

def where(input, property, *target_values = nil)

And then only search nested if target_values contains 2 or more arguments? I just like the dot notation typing more.

[andershagbard]

This shouldn't bring any breaking changes to Shopify, but could bring breaking changes to other platforms using Liquid, as it won't consider attributes with dots.

I'm not sure if that is actually the case. Doesn't Shopify support JSON metafield types? If the where filter were used on some parsed json blob, then I would think it could end up filtering on keys with a period in them.

In that case, the input would be a string, and this filter shouldn't do anything then?

[dylanahsmith]

I don't mean storing JSON in a string type field, I mean there is native support for JSON metafield types. The primary reason for that json type is so the parsed json is made accessible to liquid, meaning it could be arrays of hashes with keys that could have a period in it.

[andershagbard]

I don't mean storing JSON in a string type field, I mean there is native support for JSON metafield types. The primary reason for that json type is so the parsed json is made accessible to liquid, meaning it could be arrays of hashes with keys that could have a period in it.

Got it. Should we cover that case?

[andershagbard]

Does it make sense to add this nested feature to other filters, such as sort, uniq etc?

[andershagbard]

Opened a new PR which solves this in a way better way: #1749