Fix Liquid/C BlockBody loading issue #874
Conversation
There was a problem hiding this comment.
Looks like commit 4b1835e didn't properly revert #458, since it left in block_body.rb even though it is unused. Instead of requiring dead code we should be removing it.
liquid-c isn't going to work properly by monkey patching dead code, so we should instead update the version constraint to require liquid versions ~> 4.0
| @@ -57,6 +57,7 @@ module Liquid | |||
| require 'liquid/parser_switching' | |||
| require 'liquid/tag' | |||
| require 'liquid/block' | |||
| require 'liquid/block_body' | |||
There was a problem hiding this comment.
Why is block_body.rb even in this branch? Liquid::BlockBody isn't used by any of the code in this branch.
|
Good point, I totally missed that |
You mean Liquid 3 should depend on Liquid-C 4? Shouldn't we rather remove the BlockBody dependency from Liquid-C version 3? |
|
Oh, I thought you meant the problem was with using the latest version of liquid-c with an old version of liquid. Ya, it looks like we meant to have the liquid-c 3.x be compatible with liquid 3.x and it looks like that isn't the case |
Fixes Shopify/liquid-c#32.
Note that this PR is against the
3-0-stablebranch, not againstmaster. The problem doesn't exist on themasterbranch.cc @wjdp