Remove digest
dependency from gemspec
#202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
digest
is a standard gem and as such is bundled with Ruby 3.0+, while in previous Ruby versions it's part of stdlib.Having the gem explicitly added to the gemspec can cause issues downstream on projects using older ruby versions.
This is because it's actually possible to load the code twice, once from the stdlib and once from the gem.
As a reminder, the dependency was added as a result of this comment.
What approach did you choose and why?
Removing the dependency should have absolutely no effect on the code.
For people running Ruby 2.7 or previous, the
require "digest"
incache.rb
will load the stdlib file, while for those running Ruby 3.0+ it will load the standard gem.What should reviewers focus on?
Cross-compatibility with Ruby 2 and Ruby 3
Type of Change
Checklist
cc @rafaelfranca @alexevanczuk