Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move promotion logic inside workers #38

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Move promotion logic inside workers #38

merged 1 commit into from
Mar 28, 2023

Commits on Mar 28, 2023

  1. Move promotion logic inside workers 

    Fix: #32

This remove a lot of busy work from the server, and allow to promote
as soon as the condition is reached.

The small downside is that we need a lock between processes to ensure
two workers won't try to promote at the same time.

This also means that the mold selector is removed. It wasn't that
interesting anyway, because the Unicorn/Pitchfork architecute introduce
a bias in request distribution, worker#0 will almost always get requests
first so will almost always be the best candidate for promotion.
    @byroot
    byroot committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7239fba View commit details
    Browse the repository at this point in the history