-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore: Move mold promotion logic in workers #32
Comments
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
Fix: #32 This remove a lot of busy work from the server, and allow to promote as soon as the condition is reached. The small downside is that we need a lock between processes to ensure two workers won't try to promote at the same time. This also means that the mold selector is removed. It wasn't that interesting anyway, because the Unicorn/Pitchfork architecute introduce a bias in request distribution, worker#0 will almost always get requests first so will almost always be the best candidate for promotion.
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
Fix: #32 This remove a lot of busy work from the server, and allow to promote as soon as the condition is reached. The small downside is that we need a lock between processes to ensure two workers won't try to promote at the same time. This also means that the mold selector is removed. It wasn't that interesting anyway, because the Unicorn/Pitchfork architecute introduce a bias in request distribution, worker#0 will almost always get requests first so will almost always be the best candidate for promotion.
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
Fix: #32 This remove a lot of busy work from the server, and allow to promote as soon as the condition is reached. The small downside is that we need a lock between processes to ensure two workers won't try to promote at the same time. This also means that the mold selector is removed. It wasn't that interesting anyway, because the Unicorn/Pitchfork architecute introduce a bias in request distribution, worker#0 will almost always get requests first so will almost always be the best candidate for promotion.
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
Fix: #32 This remove a lot of busy work from the server, and allow to promote as soon as the condition is reached. The small downside is that we need a lock between processes to ensure two workers won't try to promote at the same time. This also means that the mold selector is removed. It wasn't that interesting anyway, because the Unicorn/Pitchfork architecute introduce a bias in request distribution, worker#0 will almost always get requests first so will almost always be the best candidate for promotion.
casperisfine
pushed a commit
that referenced
this issue
Mar 28, 2023
Fix: #32 This remove a lot of busy work from the server, and allow to promote as soon as the condition is reached. The small downside is that we need a lock between processes to ensure two workers won't try to promote at the same time. This also means that the mold selector is removed. It wasn't that interesting anyway, because the Unicorn/Pitchfork architecute introduce a bias in request distribution, worker#0 will almost always get requests first so will almost always be the best candidate for promotion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, it's the master process that keeps an eye on workers and chose to promote one of them when some condition is reached.
Pros:
Cons:
Since that's a lot of cons, I think we should explore moving this logic into the workers.
Pros:
Cons:
The logic would be something like:
The text was updated successfully, but these errors were encountered: