[Resource Picker] change the default value of showHidden to true
#981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannachen
force-pushed
the
app-bridge/fix/resource-picker-option
branch
from
8749a38
to
a96fda2
Compare
hannachen
force-pushed
the
app-bridge/fix/resource-picker-option
branch
from
a96fda2
to
8d4b6c7
Compare
hannachen
force-pushed
the
app-bridge/fix/resource-picker-option
branch
from
8d4b6c7
to
37524a5
Compare
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Resolves https://github.com/Shopify/app-bridge/issues/717
showHiddendefault value was changed tofalsewhen App Bridge first launched, but the option didn't actually take effect due to a bug. Now that the bug is fixed by https://github.com/Shopify/web/pull/10116, it exposed behaviour inconsistency with EASDK.More details on the issue here: https://github.com/Shopify/app-bridge/issues/721
WHAT is this pull request doing?
Change the default value back to
truein order to match the expected behaviour of EASDK, as well as other admin sections.