Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Increase contrast of dark border divider #177

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Increase contrast of dark border divider #177

merged 2 commits into from
Feb 11, 2021

Conversation

alex-page
Copy link
Member

@alex-page alex-page commented Feb 10, 2021 •
edited

Resolve the issue where borders look darker then surfaces

Before After
image Screen Shot 2021-02-10 at 2 04 22 PM

@alex-page alex-page self-assigned this Feb 10, 2021
AndrewMusgrave
AndrewMusgrave approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

dewyze
dewyze approved these changes Feb 11, 2021
View reviewed changes
Copy link

@dewyze dewyze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a designer, but I can confirm that I can now see the line.

🙈 🙉 👾

alex-page
alex-page commented Feb 11, 2021
View reviewed changes
src/configs/base.ts Outdated Show resolved Hide resolved
@alex-page alex-page temporarily deployed to polaris-toke-alex-page--gnfv7q February 11, 2021 15:28 Inactive
@alex-page alex-page merged commit df1afb6 into main Feb 11, 2021
@alex-page alex-page deleted the alex-page-patch-1 branch February 11, 2021 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dewyze dewyze dewyze approved these changes

@AndrewMusgrave AndrewMusgrave AndrewMusgrave approved these changes

Assignees

@alex-page alex-page

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-page @dewyze @AndrewMusgrave @kaelig