Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Expose mergeConfigs and Configs from dist-modern #180

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Mar 2, 2021

These two exports are part of the public api, consumed by polaris-react
Lets expose them at the top level of modern so apps don't have go reach
deep

This helps set us up for the future where we switch importing @shopify/polaris-tokens to look at the modern stuff instead of pulling in legacy things.

Once this is merged and released we can update polaris-react to stop it reaching deep:

- import {mergeConfigs} from '@shopify/polaris-tokens/dist-modern/utils';
+ import {mergeConfigs} from '@shopify/polaris-tokens/dist-modern';

// and

- import type {Config} from '@shopify/polaris-tokens/dist-modern/types';
+ import type {Config} from '@shopify/polaris-tokens/dist-modern';

These two files are part of the public api, consumed by polaris-react
Lets expose them at the top level of modern so apps don't have go reach
deep
@kaelig kaelig temporarily deployed to polaris-toke-public-api-elxtta March 2, 2021 01:06 Inactive
@BPScott BPScott requested review from alex-page and kaelig March 2, 2021 01:06
Copy link
Contributor

@kaelig kaelig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense!

Can you add an item to CHANGELOG.md?

@BPScott BPScott temporarily deployed to polaris-toke-public-api-elxtta March 3, 2021 00:15 Inactive
@BPScott BPScott merged commit f86886f into main Mar 3, 2021
@BPScott BPScott deleted the public-api branch March 3, 2021 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants