Move onSurface.onSurfaceBackground to surface.surfaceSearchField

[AdamVig]

Commits

• Move onSurface.onSurfaceBackground to surface.surfaceSearchField
  This fixes the non-unique figmaName of this variant, too, which
  unblocks Add test to enforce unique figmaName values #178.

[alex-page]

This makes sense to me but will need to be documented in CHANGELOG.md as it will likely break consumers using the current value.

[kyledurand]

The name change makes sense just be sure to add an entry to the changelog like Alex mentioned. Just under <!-- ## [Unreleased] --> at the top of the file

[AdamVig]

@alex-page @kyledurand Thanks for the reviews!

I added this to the changelog in the unreleased section. I made sure to mark this as a breaking change (cc @kaelig if that requires any special attention from you).

[kyledurand]

👍

[kaelig]

There might be a few vault pages and Polaris pages that need updating — can you look into it?

[AdamVig]

@kaelig I found the following references of --p-on-surface-background and onSurfaceBackground:

• polaris-styleguide
  • Three definitions in web/styleguide-demo/Demo/test/Demo.test.tsx, but it looks like they might be automatically generated
• polaris-react
  • Three uses in src/components/TopBar/components/SearchField/SearchField.scss.
  • Documentation in documentation/Color system.md, but it looks like it is automatically updated when the tokens change.
  • Defined in src/components/README.md, does not seem to be automatically updated when tokens change.
• No references that I could find in Vault.

I don't think I have time to cut a release of polaris-tokens and update those other repositories in the near future, but if that work is absolutely necessary in order to merge this, I can do it in a few weeks.

[alex-page]

I can do the release this should be good to merge.

[AdamVig]

Thanks, @alex-page!