[IndexFilters] consolidate se23 styles and logic

[gwyneplaine]

WHY are these changes introduced?

Fixes #9938

WHAT is this pull request doing?

• Consolidate se23 styles
• Consolidate se23 logic
• Remove custom FilterButton and replace it with direct invocations of the Polaris Button instead. This seems safe to do because:
  • even though we export FilterButton from the root of IndexFilters, we do not actually expose it directly from the polaris-react entrypoint.
  • AFAIK, noone is reaching into our cjs/esm builds to grabFilterButton (see grokt)
  • Just to be sure, also doesn't look like anyone is importing FilterButton from @shopify/polaris either. (see grokt)
  • That said I can see an argument being made for providing convenience wrappers to alleviate repetitive config, so deferring to the team. 👍 Happy to revert if necessary 👍

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide

[laurkim]

Nice 🚀

Small issue with spacing of filter and sort buttons on xs and sm breakpoints but other than that, looks great 🙌

[sophschneider]

Nice! removing the custom button is good w me :) Can you add a changeset for it?

[gwyneplaine]

Nice 🚀

Small issue with spacing of filter and sort buttons on xs and sm breakpoints but other than that, looks great 🙌

Looks to be an inadvertent bugfix. New spacing is true to Figma

Production:

[gwyneplaine]

This was overriding the .TabsWrapper height invocation on mdDown above (line 36).
As this class is only applied at mdDown, safe for us to remove this duplicative height rule.