Update changeset config to reflect changes from main #10253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwyneplaine
force-pushed
the
update/changeset-config
branch
from
e4a5b40
to
20df279
Compare
gwyneplaine
changed the title
gwyneplaine
requested review from
jesstelford,
dominikwilkowski and
sam-b-rose
sophschneider
pushed a commit
that referenced
this pull request
Sep 19, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? #10238 merged in changes from main, inclusive of removing the `polaris-cli` and `polaris-codemods` packages. Unfortunately these changes were not reflected in the changeset config resulting in errors when running `yarn changeset` due to ignores being set up for the aforementioned removed packages. Error:  <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes removed packages (`polaris-cli` `polaris-codemods`) from changest config ignore. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 Run `yarn changeset` locally on branch.
Merged
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Shopify#10238 merged in changes from main, inclusive of removing the `polaris-cli` and `polaris-codemods` packages. Unfortunately these changes were not reflected in the changeset config resulting in errors when running `yarn changeset` due to ignores being set up for the aforementioned removed packages. Error:  <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? * Removes removed packages (`polaris-cli` `polaris-codemods`) from changest config ignore. <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 Run `yarn changeset` locally on branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
#10238 merged in changes from main, inclusive of removing the
polaris-cliandpolaris-codemodspackages. Unfortunately these changes were not reflected in the changeset config resulting in errors when runningyarn changesetdue to ignores being set up for the aforementioned removed packages.Error:
WHAT is this pull request doing?
polaris-clipolaris-codemods) from changest config ignore.How to 🎩
Run
yarn changesetlocally on branch.