Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create migration for replacing v11 space custom properties #10305

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Create migration for replacing v11 space custom properties #10305

merged 4 commits into from
Sep 29, 2023

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Sep 1, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #10445

WHAT is this pull request doing?

This PR creates a migration for deprecated space custom properties in v12 using the generic codemod styles-replace-custom-property.

v12-styles-replace-custom-property-space

Deprecated CSS Custom Property Replacement Value
--p-space-05 --p-space-050
--p-space-1 --p-space-100
--p-space-1_5-experimental --p-space-150
--p-space-2 --p-space-200
--p-space-3 --p-space-300
--p-space-4 --p-space-400
--p-space-5 --p-space-500
--p-space-6 --p-space-600
--p-space-8 --p-space-800
--p-space-10 --p-space-1000
--p-space-12 --p-space-1200
--p-space-16 --p-space-1600
--p-space-20 --p-space-2000
--p-space-24 --p-space-2400
--p-space-28 --p-space-2800
--p-space-32 --p-space-3200

@lgriffee lgriffee self-assigned this Sep 1, 2023
@lgriffee lgriffee marked this pull request as ready for review September 18, 2023 15:01
@lgriffee
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @lgriffee! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230918165951
yarn add @shopify/polaris@0.0.0-snapshot-release-20230918165951

This was referenced Sep 18, 2023
Closed
Closed
@lgriffee lgriffee merged commit 1b36b92 into main Sep 29, 2023
10 checks passed
@lgriffee lgriffee deleted the replace-custom-property-space branch September 29, 2023 00:45
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 29, 2023
Merged
laurkim pushed a commit that referenced this pull request Oct 4, 2023
@shopify-github-actions-access @github-actions
Version Packages (#10780)
046894b 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.23.0

### Minor Changes

- [#10579](#10579)
[`b5a3622ca`](b5a3622)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created
migration to replace deprecated `color` custom properties in Polaris
v12.0.0


- [#10304](#10304)
[`eb93b7f1c`](eb93b7f)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `font` custom properties in polaris-react v12.0.0


- [#10506](#10506)
[`d901a07a3`](d901a07)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `border` custom properties in polaris-react v12.0.0


- [#10305](#10305)
[`1b36b9256`](1b36b92)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `space` custom properties in polaris-react v12.0.0


- [#10306](#10306)
[`dbae87e58`](dbae87e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `shadow` custom properties in polaris-react v12.0.0

## @shopify/polaris@11.26.0

### Minor Changes

- [#10788](#10788)
[`82f10e830`](82f10e8)
Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the
IndexFiltersManager component

## polaris.shopify.com@0.58.5

### Patch Changes

- Updated dependencies
\[[`82f10e830`](82f10e8)]:
    -   @shopify/polaris@11.26.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
@shopify-github-actions-access @github-actions @mrcthms
Version Packages (#10780)
0c483ac 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

- [#10579](#10579)
[`b5a3622ca`](b5a3622)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created
migration to replace deprecated `color` custom properties in Polaris
v12.0.0

- [#10304](#10304)
[`eb93b7f1c`](eb93b7f)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `font` custom properties in polaris-react v12.0.0

- [#10506](#10506)
[`d901a07a3`](d901a07)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `border` custom properties in polaris-react v12.0.0

- [#10305](#10305)
[`1b36b9256`](1b36b92)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `space` custom properties in polaris-react v12.0.0

- [#10306](#10306)
[`dbae87e58`](dbae87e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `shadow` custom properties in polaris-react v12.0.0

- [#10788](#10788)
[`82f10e830`](82f10e8)
Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the
IndexFiltersManager component

- Updated dependencies
\[[`82f10e830`](82f10e8)]:
    -   @shopify/polaris@11.26.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mrcthms pushed a commit that referenced this pull request Oct 12, 2023
@shopify-github-actions-access @github-actions @mrcthms
Version Packages (#10780)
b67ab25 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.

- [#10579](#10579)
[`b5a3622ca`](b5a3622)
Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created
migration to replace deprecated `color` custom properties in Polaris
v12.0.0

- [#10304](#10304)
[`eb93b7f1c`](eb93b7f)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `font` custom properties in polaris-react v12.0.0

- [#10506](#10506)
[`d901a07a3`](d901a07)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `border` custom properties in polaris-react v12.0.0

- [#10305](#10305)
[`1b36b9256`](1b36b92)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `space` custom properties in polaris-react v12.0.0

- [#10306](#10306)
[`dbae87e58`](dbae87e)
Thanks [@lgriffee](https://github.com/lgriffee)! - Created migration to
replace deprecated `shadow` custom properties in polaris-react v12.0.0

- [#10788](#10788)
[`82f10e830`](82f10e8)
Thanks [@mrcthms](https://github.com/mrcthms)! - Deprecated the
IndexFiltersManager component

- Updated dependencies
\[[`82f10e830`](82f10e8)]:
    -   @shopify/polaris@11.26.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@lgriffee
Create migration for replacing v11 space custom properties (Shopify…
0d403c8 
…#10305)

### WHY are these changes introduced?

Fixes Shopify#10445 

### WHAT is this pull request doing?
This PR creates a migration for deprecated `space` custom properties in
v12 using the generic codemod
[`styles-replace-custom-property`](Shopify#8265).

#### v12-styles-replace-custom-property-space
| Deprecated CSS Custom Property | Replacement Value |
| ----------------------------------------- |
---------------------------------- |
| `--p-space-05` | `--p-space-050` | 
| `--p-space-1` | `--p-space-100` | 
| `--p-space-1_5-experimental` | `--p-space-150` | 
| `--p-space-2` | `--p-space-200` | 
| `--p-space-3` | `--p-space-300` |
| `--p-space-4` | `--p-space-400` | 
| `--p-space-5` | `--p-space-500` | 
| `--p-space-6` | `--p-space-600` | 
| `--p-space-8` | `--p-space-800` | 
| `--p-space-10` | `--p-space-1000` | 
| `--p-space-12` | `--p-space-1200` | 
| `--p-space-16` | `--p-space-1600` | 
| `--p-space-20` | `--p-space-2000` | 
| `--p-space-24` | `--p-space-2400` | 
| `--p-space-28` | `--p-space-2800` | 
| `--p-space-32` | `--p-space-3200` |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronccasanova aaronccasanova aaronccasanova approved these changes

Assignees

@lgriffee lgriffee

Labels
Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create space migration
2 participants
@lgriffee @aaronccasanova