Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create space migration #10445

Closed
Tracked by #10301
lgriffee opened this issue Sep 13, 2023 · 0 comments · Fixed by #10305
Closed
Tracked by #10301

Create space migration #10445

lgriffee opened this issue Sep 13, 2023 · 0 comments · Fixed by #10305
Assignees
@lgriffee

Comments

@lgriffee
Copy link
Member

No description provided.

@lgriffee lgriffee mentioned this issue Sep 13, 2023
Closed
@lgriffee lgriffee self-assigned this Sep 13, 2023
@lgriffee lgriffee mentioned this issue Sep 13, 2023
Merged
lgriffee added a commit that referenced this issue Sep 29, 2023
@lgriffee
Create migration for replacing v11 space custom properties (#10305)
1b36b92 
### WHY are these changes introduced?

Fixes #10445 

### WHAT is this pull request doing?
This PR creates a migration for deprecated `space` custom properties in
v12 using the generic codemod
[`styles-replace-custom-property`](#8265).

#### v12-styles-replace-custom-property-space
| Deprecated CSS Custom Property | Replacement Value |
| ----------------------------------------- |
---------------------------------- |
| `--p-space-05` | `--p-space-050` | 
| `--p-space-1` | `--p-space-100` | 
| `--p-space-1_5-experimental` | `--p-space-150` | 
| `--p-space-2` | `--p-space-200` | 
| `--p-space-3` | `--p-space-300` |
| `--p-space-4` | `--p-space-400` | 
| `--p-space-5` | `--p-space-500` | 
| `--p-space-6` | `--p-space-600` | 
| `--p-space-8` | `--p-space-800` | 
| `--p-space-10` | `--p-space-1000` | 
| `--p-space-12` | `--p-space-1200` | 
| `--p-space-16` | `--p-space-1600` | 
| `--p-space-20` | `--p-space-2000` | 
| `--p-space-24` | `--p-space-2400` | 
| `--p-space-28` | `--p-space-2800` | 
| `--p-space-32` | `--p-space-3200` |
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@lgriffee
Create migration for replacing v11 space custom properties (Shopify…
0d403c8 
…#10305)

### WHY are these changes introduced?

Fixes Shopify#10445 

### WHAT is this pull request doing?
This PR creates a migration for deprecated `space` custom properties in
v12 using the generic codemod
[`styles-replace-custom-property`](Shopify#8265).

#### v12-styles-replace-custom-property-space
| Deprecated CSS Custom Property | Replacement Value |
| ----------------------------------------- |
---------------------------------- |
| `--p-space-05` | `--p-space-050` | 
| `--p-space-1` | `--p-space-100` | 
| `--p-space-1_5-experimental` | `--p-space-150` | 
| `--p-space-2` | `--p-space-200` | 
| `--p-space-3` | `--p-space-300` |
| `--p-space-4` | `--p-space-400` | 
| `--p-space-5` | `--p-space-500` | 
| `--p-space-6` | `--p-space-600` | 
| `--p-space-8` | `--p-space-800` | 
| `--p-space-10` | `--p-space-1000` | 
| `--p-space-12` | `--p-space-1200` | 
| `--p-space-16` | `--p-space-1600` | 
| `--p-space-20` | `--p-space-2000` | 
| `--p-space-24` | `--p-space-2400` | 
| `--p-space-28` | `--p-space-2800` | 
| `--p-space-32` | `--p-space-3200` |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgriffee lgriffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create migration for replacing v11 space custom properties Shopify/polaris
1 participant
@lgriffee