Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add React peer dependency for @shopify/polaris-icons #11825

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add React peer dependency for @shopify/polaris-icons #11825

merged 2 commits into from
Apr 4, 2024

Conversation

ryanwilsonperkin
Copy link
Member

WHY are these changes introduced?

This package depedends on React as a peer dependency in its produced output for SVG icons that end up rended as React components.

Extracted from #11799 which highlighted the issue

WHAT is this pull request doing?

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

@ryanwilsonperkin ryanwilsonperkin mentioned this pull request Apr 2, 2024
Merged
@ryanwilsonperkin
Add React peer dependency for @shopify/polaris-icons
6db39eb 
This package depedends on React as a peer dependency in its produced
output for SVG icons that end up rended as React components.
@ryanwilsonperkin @sam-b-rose
Update polaris-icons/package.json
12bfe85 
Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
@ryanwilsonperkin ryanwilsonperkin merged commit fd5b31d into main Apr 4, 2024
9 checks passed
@ryanwilsonperkin ryanwilsonperkin deleted the polaris-icons-react-peer branch April 4, 2024 13:58
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 4, 2024
Merged
sam-b-rose pushed a commit that referenced this pull request Apr 4, 2024
@shopify-github-actions-access @github-actions
Version Packages (#11823)
0a18875 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@8.10.0

### Minor Changes

- [#11816](#11816)
[`4b730c84d`](4b730c8)
Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added some
icons for image editing

### Patch Changes

- [#11825](#11825)
[`fd5b31d59`](fd5b31d)
Thanks [@ryanwilsonperkin](https://github.com/ryanwilsonperkin)! - Add
missing peer dependency on React

## @shopify/polaris@12.26.0

### Minor Changes

- [#11785](#11785)
[`2a2f635ba`](2a2f635)
Thanks [@mrcthms](https://github.com/mrcthms)! - Added the
`defaultPaginatedSelectAllText` prop to `IndexTable` to support
customizing the label of the checkbox in the header that selects all
rows across pages when the table `hasMoreItems`

### Patch Changes

- [#11833](#11833)
[`810532c58`](810532c)
Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - Revert responsive
text style updates


- [#11810](#11810)
[`66dc0392a`](66dc039)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed Shift +
click selection of `IndexTable.Row` not working in Firefox


- [#11811](#11811)
[`9aea67322`](9aea673)
Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated
`heading2xl` variant in `Text` component


- [#11817](#11817)
[`936765c92`](936765c)
Thanks [@sam-b-rose](https://github.com/sam-b-rose)! - [IndexTable]
Initially hide the scrollbar and update scrollbar padding


- [#11819](#11819)
[`35eb10c4f`](35eb10c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added multi
select functionality to AlphaPicker

- Updated dependencies
\[[`fd5b31d59`](fd5b31d),
[`4b730c84d`](4b730c8)]:
    -   @shopify/polaris-icons@8.10.0

## @shopify/polaris-migrator@0.28.6

### Patch Changes

- [#11813](#11813)
[`c49809998`](c498099)
Thanks [@lgriffee](https://github.com/lgriffee)! - Removed `Text`
`heading2xl` and associated tokens from v14 font migration

## polaris.shopify.com@0.67.2

### Patch Changes

- [#11796](#11796)
[`c8dc01330`](c8dc013)
Thanks [@sarahill](https://github.com/sarahill)! - Updated common action
pattern guidance


- [#11811](#11811)
[`9aea67322`](9aea673)
Thanks [@lgriffee](https://github.com/lgriffee)! - Undeprecated
`heading2xl` variant in `Text` component

- Updated dependencies
\[[`fd5b31d59`](fd5b31d),
[`810532c58`](810532c),
[`66dc0392a`](66dc039),
[`9aea67322`](9aea673),
[`4b730c84d`](4b730c8),
[`2a2f635ba`](2a2f635),
[`936765c92`](936765c),
[`35eb10c4f`](35eb10c)]:
    -   @shopify/polaris-icons@8.10.0
    -   @shopify/polaris@12.26.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Apr 9, 2024
Merged
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@ryanwilsonperkin @sam-b-rose
Add React peer dependency for @shopify/polaris-icons (Shopify#11825)
d283623 
### WHY are these changes introduced?

This package depedends on React as a peer dependency in its produced
output for SVG icons that end up rended as React components.

Extracted from Shopify#11799 which
highlighted the issue

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

  Include a video if your changes include interactive content.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

  <details>
    <summary>Summary of your gif(s)</summary>
    <img src="..." alt="Description of what the gif shows">
  </details>
-->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Sam Rose <11774595+sam-b-rose@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-page alex-page alex-page approved these changes

@aaronccasanova aaronccasanova aaronccasanova approved these changes

@sam-b-rose sam-b-rose Awaiting requested review from sam-b-rose sam-b-rose is a code owner

@jesstelford jesstelford Awaiting requested review from jesstelford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ryanwilsonperkin @jesstelford @sam-b-rose @alex-page @aaronccasanova